Open
Conversation
ulhas
approved these changes
Feb 24, 2021
|
|
||
| import Routes from "./app/components/routing/Routes"; | ||
|
|
||
| import "antd/dist/antd.css"; |
There was a problem hiding this comment.
Make a global css and put this there. Import the global css here.
| const [text, setText] = useState(""); | ||
|
|
||
| useEffect(() => { | ||
| Axios.get(source).then((result) => { |
There was a problem hiding this comment.
it's better to wrap third party library like these for abstraction
| !isAuthenticated ? ( | ||
| <Redirect to="/login" /> | ||
| ) : privacyPolicyAccepted ? ( | ||
| <Component {...props} /> |
| <Content> | ||
| <div className="App"> | ||
| <Switch> | ||
| <Route exact path="/" component={Login} /> |
There was a problem hiding this comment.
These routes can be extracted to a new component
| style={{ | ||
| display: "flex", | ||
| justifyContent: "center", | ||
| padding: "20px", |
There was a problem hiding this comment.
if possible use spacer from antd for laying out elements
|
The comments are optional. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in the auth module
Changes in the app module