Fix and add various functions related to http/2#115
Open
etcimon wants to merge 1 commit intoD-Programming-Deimos:masterfrom
Open
Fix and add various functions related to http/2#115etcimon wants to merge 1 commit intoD-Programming-Deimos:masterfrom
etcimon wants to merge 1 commit intoD-Programming-Deimos:masterfrom
Conversation
…stants to support http/2
schveiguy
reviewed
Aug 8, 2025
Contributor
schveiguy
left a comment
schveiguy
left a comment
There was a problem hiding this comment.
I can try and review this, but I'm new to how deimos openssl works. So I'm unsure how to verify these changes are correct.
Just naive searching for e.g. bio_method_st, I don't see how this is defined for all versions, to make sure this works on all of them.
| c_ulong num_read; | ||
| c_ulong num_write; | ||
| ulong num_read; | ||
| ulong num_write; |
Contributor
There was a problem hiding this comment.
Why switch this? Isn't c_ulong correct?
|
|
||
| } // OPENSSL_NO_SSL_INTERN | ||
|
|
||
| alias ALPNCallback = int function(SSL *ssl, const(char) **output, ubyte* outlen, const(char) *input, uint inlen, void *arg); |
Contributor
There was a problem hiding this comment.
Should this not be called SSL_CTX_alpn_select_cb_func like in the .h file? Not sure whether it matters or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those are some important fixes on BIO structs and functions added including SSL_read_ex which wasn't defined.