Open
Conversation
DGh0st
requested changes
Nov 2, 2025
Owner
DGh0st
left a comment
DGh0st
left a comment
There was a problem hiding this comment.
As is this is not going to be merged.
Looks like there are bunch of AI generated .md files which aren't really helpful for anything so should not be included. And the .log file is also not helpful should not be included.
The changes break lot of things that need to be fixed if you want this merged:
- Removes armv7 support (32-bit devices) which is what this tweak was mainly focused towards.
- Conversion to ARC is wrong. Should not be calling
CFReleaseon prefs. Its needs to be aCFBridgingReleasebefore casting toNSDictionary *. - Older devices don't have haptic feedback, it needs to use haptic feedback if supported otherwise should use the old approach of vibrations.
- All the gesture methods are being removed which would basically break all the functionality, which needs to be reverted.
- Preferences are not being compiled anymore which it still should.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.