-
Notifications
You must be signed in to change notification settings - Fork 510
[dspace-7_x] Add paginated vocabulary search with 'Show previous/next results' controls in hierarchical browse #4504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lts' controls in hierarchical browse
|
@ZahraaChreim-Atmire : Could you please create a |
|
|
Hi @ZahraaChreim-Atmire, |
…hical-browse-pagination-7_x
…2284_fix-issue4500-hierarchical-browse-pagination-7_x'
…ubject category page
|
Closing & reopening to get tests to run again. |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-4504-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-4504-to-dspace-8_x
git switch --create backport-4504-to-dspace-8_x
git cherry-pick -x 1982f7593f84e57b52cb24bed2f5417ffabc4644 231da9c2c50f9043a1f5090833aa8429b7d71db2 9aacba60b4c296b9b0e9561d4d15b83d006193d1 |
References
Description
Added paging state management to the vocabulary treeview service, updating after each query based on whether previous or next pages exist; this state is exposed to the component to conditionally render navigation buttons in the hierarchical vocabulary browse.
Instructions for Reviewers
List of changes in this PR:
currentPage,totalPages,showNextPageSubject, andshowPreviousPageSubjectto thevocabulary-treeview.serviceto manage and expose pagination state.searchByQueryAndPage(query, selectedItems, page)to support page-specific vocabulary search requests. The existingsearchByQuerymethod was updated to call this with page1by default.searchByQueryAndPageto extract pagination info from the search response and update theshowNextPageSubjectandshowPreviousPageSubjectbased on whether more pages are available.showNextPage$andshowPreviousPage$in the component, derived fromshowNextPageSubject, andshowPreviousPageSubject, to reactively control the display of pagination buttons.loadNextPageand `loadPreviousPage to trigger paging behavior.To test this PR:
label="label1"throughlabel="label100"and corresponding values like"value test 1"to"value test 100"./browse/srsc).label.Expected behavior after applying this PR:
First page:

Intermediate page:

Last page:

Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.