134983: new funnel icon in search scope

[bram-maegerman]

References

Fixes #1394

Description

This PR adds a funnel icon to the search scope button in front of "All of DSpace"

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

• Go to {ui}//search?spc.page=1

A funnel icon should be visible in front of the "All of DSpace" text in the scope search button

Checklist

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR fixes an issue ticket, I've linked them together.

[nwoodward]

👍 Thanks @bram-maegerman. The filter icon looks good. I'm not sure about the failing test, but hopefully it will be fixed when it runs again.

[tdonohue]

Closing and reopening to trigger tests to rerun. GitHub seems to have had a hiccup in running tests in this PR, and closing & reopening will hopefully fix it.

[alanorth]

For reference, here's what it looks like:

I wish it was not a solid icon, but there is no alternative on Font Awesome Free. An empty funnel usually implies no filter is active.

Also, @bram-maegerman I would recommend rebasing/squashing this so we don't get the extra "fix up" changes from the draft iterations on the main branch. They create extra noise in the commit history that is not necessary. You can do it on your side and force push the branch, or we can do it when we merge here. Thank you.

[bram-maegerman]

Thanks for the feedback @alanorth, and sorry for getting back to you so late.
I cleaned up the source branch commits and looked at it again.
Here is what it looks like now.

[alanorth]

Thanks @bram-maegerman! Looks good. A very simple fix that improves UX using common patterns. I think we should port it to all active DSpace 7+ branches. @tdonohue do you agree?

[tdonohue]

👍 Thanks @bram-maegerman ! I gave this a quick look and it looks great to me. I agree with @alanorth that this small fix should be applied to all maintenance branches. I'll merge this and get it ported to 9.x, 8.x and 7.x

[dspace-bot]

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-4767-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-4767-to-dspace-7_x
git switch --create backport-4767-to-dspace-7_x
git cherry-pick -x 6f15b068215ca40b6273ae1f1cb62c278f6c81a7

[dspace-bot]

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-4767-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-4767-to-dspace-8_x
git switch --create backport-4767-to-dspace-8_x
git cherry-pick -x 6f15b068215ca40b6273ae1f1cb62c278f6c81a7

[dspace-bot]

Successfully created backport PR for dspace-9_x:

• [Port dspace-9_x] 134983: new funnel icon in search scope #5034