[Docker] Fix bug in docker-deploy test by always pulling backend image from docker.io
#5016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
added
bug
1 APPROVAL
Member
Author
|
👍 Merging immediately as all automated tests pass & this fixes a build bug on all maintenance branches. |
Contributor
|
Git push to origin failed for dspace-7_x with exitcode 1 |
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
Member
Author
|
Verified this fixed the bug in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, our
docker-deploystep is failing (on all active branches) whenever it runs post-merger of a PR.Examples:
The reason for this failure is that we're attempting to pull the backend image from ghcr.io (in order to start a backend to test against). But, we run into a permissions error every time as our ghcr.io images are private (and only used for build verifications).
This small PR just updates our GitHub actions
docker.ymlto ensure the backend image is always pulled fromdocker.io(our public images). This fixes a minor flaw in the newdocker-deploytests added in #4987(NOTE: The frontend images continue to be taken from
ghcr.ioin order to test the latest built frontend image. This remains unchanged because thedspace-angularrepo can easily pull frontend images fromghcr.io. It just doesn't have permissions to pull the backend images)Instructions for Reviewers
docker.ymlscript. Therefore, assuming our automated tests all pass, I'll merge this immediately and port to all active branches (as this same flaw appears on all branches)