Open
Conversation
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
src/tweetEmbed.ts:194
- The stdio option 'overlapped' is unusual; standard values are typically 'pipe', 'inherit', or 'ignore'. Verify that 'overlapped' is supported by the child process API or replace it with 'pipe' if appropriate.
stdio: ["overlapped", "ignore", "inherit"],
src/tweetEmbed.ts:165
- There is a potential risk of division by zero if video.duration_millis is 0. Consider adding a check to ensure duration_millis is greater than 0 before performing the division.
const br = Math.floor(size / (video as VideoInfo).duration_millis);
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/tweetEmbed.ts:197
- The stdio option 'overlapped' is not a standard value for spawn. It should likely be replaced with 'pipe' to ensure proper stream handling.
const child = spawn("ffmpeg", args, { stdio: ["overlapped", "ignore", "inherit"] });
…-scripts into feat/tweetVideo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.