Skip to content

feat: support video tweets#6

Open
DTrombett wants to merge 47 commits intomainfrom
feat/tweetVideo
Open

feat: support video tweets#6
DTrombett wants to merge 47 commits intomainfrom
feat/tweetVideo

Conversation

@DTrombett
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings April 13, 2025 16:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

src/tweetEmbed.ts:194

  • The stdio option 'overlapped' is unusual; standard values are typically 'pipe', 'inherit', or 'ignore'. Verify that 'overlapped' is supported by the child process API or replace it with 'pipe' if appropriate.
stdio: ["overlapped", "ignore", "inherit"],

src/tweetEmbed.ts:165

  • There is a potential risk of division by zero if video.duration_millis is 0. Consider adding a check to ensure duration_millis is greater than 0 before performing the division.
const br = Math.floor(size / (video as VideoInfo).duration_millis);

@DTrombett DTrombett requested a review from Copilot April 14, 2025 14:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/tweetEmbed.ts:197

  • The stdio option 'overlapped' is not a standard value for spawn. It should likely be replaced with 'pipe' to ensure proper stream handling.
const child = spawn("ffmpeg", args, { stdio: ["overlapped", "ignore", "inherit"] });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants