Skip to content

Properly set TC readout window sizes for daqsystemtest after updates in config #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wesketchum wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Properly set TC readout window sizes for daqsystemtest after updates in config #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4b141a1
RandomTCMaker conf updated
alessandrothea Nov 12, 2025
ad16bfb
Replaced rtcm offset with backshift to highight the value is subtrack…
alessandrothea Nov 15, 2025
01400de
candidate_backshift_ts changed to s64
alessandrothea Nov 15, 2025
6f42c77
Re-creating `def-random-readout`
alessandrothea Nov 24, 2025
cb6721d
Merge pull request #265 from DUNE-DAQ/thea/random_tc_config
wesketchum Nov 25, 2025
a6ca971
Properly set TC readout window sizes for daqsystemtest after updates …
wesketchum Nov 25, 2025
97aa623
Revert "RandomTCMaker conf updated"
wesketchum Nov 25, 2025
b1cb1f4
Merge pull request #272 from DUNE-DAQ/revert-265-thea/random_tc_config
wesketchum Nov 26, 2025
6c831e6
Reapply "RandomTCMaker conf updated"
wesketchum Nov 26, 2025
9e42336
Merge branch 'wketchum/FixTCReadoutWindow' of github.com:DUNE-DAQ/daq…
wesketchum Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion config/daqsystemtest/moduleconfs.data.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,10 @@
<attr name="template_for" type="class" val="RandomTCMakerModule"/>
<attr name="trigger_rate_hz" type="float" val="1"/>
<attr name="time_distribution" type="enum" val="kUniform"/>
<rel name="tc_readout" class="TCReadoutMap" id="def-random-readout"/>
<attr name="candidate_type_name" type="string" val="kRandom"/>
<attr name="candidate_backshift_ts" type="s64" val="0"/>
<attr name="candidate_window_before_ts" type="u32" val="2000"/>
<attr name="candidate_window_after_ts" type="u32" val="5"/>
</obj>

<obj class="RequestHandler" id="def-data-request-handler">
Expand Down
9 changes: 5 additions & 4 deletions integtest/fake_data_producer_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,12 @@

doublewindow_conf.config_substitutions.append(
data_classes.attribute_substitution(
obj_class="TCReadoutMap",
obj_id = "def-random-readout",
obj_class="RandomTCMakerConf",
obj_id = "random-tc-generator",
updates={
"time_before": 2000,
"time_after": 2001,
"candidate_backshift_ts": 0,
"candidate_window_before_ts": 2000,
"candidate_window_after_ts": 2001,
},
)
)
Expand Down
9 changes: 5 additions & 4 deletions integtest/long_window_readout_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,12 @@
)
conf_dict.config_substitutions.append(
data_classes.attribute_substitution(
obj_class="TCReadoutMap",
obj_id = "def-random-readout",
obj_class="RandomTCMakerConf",
obj_id = "random-tc-generator",
updates={
"time_before": readout_window_time_before,
"time_after": readout_window_time_after,
"candidate_backshift_ts": 0,
"candidate_window_before_ts": readout_window_time_before,
"candidate_window_after_ts": readout_window_time_after,
},
)
)
Expand Down
18 changes: 10 additions & 8 deletions integtest/readout_type_scan_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,11 +232,12 @@

daphne_stream_conf.config_substitutions.append(
data_classes.attribute_substitution(
obj_class="TCReadoutMap",
obj_id = "def-random-readout",
obj_class="RandomTCMakerConf",
obj_id = "random-tc-generator",
updates={
"time_before": 62000,
"time_after": 500,
"candidate_backshift_ts": 0,
"candidate_window_before_ts": 62000,
"candidate_window_after_ts": 500,
},
)
)
Expand All @@ -246,11 +247,12 @@
daphne_conf.frame_file = "asset://?checksum=a8990a9eb3a505d4ded62dfdfa9e2681" # np02vd_run036012_sample_membrane_pds
daphne_conf.config_substitutions.append(
data_classes.attribute_substitution(
obj_class="TCReadoutMap",
obj_id = "def-random-readout",
obj_class="RandomTCMakerConf",
obj_id = "random-tc-generator",
updates={
"time_before": 62000,
"time_after": 500,
"candidate_backshift_ts": 0,
"candidate_window_before_ts": 62000,
"candidate_window_after_ts": 500,
},
)
)
Expand Down
2 changes: 1 addition & 1 deletion integtest/trigger_bitwords_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@
data_classes.attribute_substitution(
obj_id="random-tc-generator",
obj_class="RandomTCMakerConf",
updates={"trigger_rate_hz": 40},)
updates={"trigger_rate_hz": 40, "candidate_backshift_ts": 0, "candidate_window_before_ts": 62500, "candidate_window_after_ts": 62500},)
)
coincidence_bitword_conf.config_substitutions.append(
data_classes.attribute_substitution(
Expand Down