Added support for additional configuration-substitution options... #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2025 16:06
… as when the replacement entity is a configuration object instead of just a simple value.
Member
|
I would be tempted to not keep backwards compatibility, as that would result in another rather disruptive changeset down the line. Thoughts? |
eflumerf
approved these changes
Sep 2, 2025
Member
eflumerf
left a comment
eflumerf
left a comment
There was a problem hiding this comment.
Works as-is, though see comment about doing things all at once instead of over time.
Contributor
Author
|
Yes, I can see the value in dealing with all of the changes now. And, they don't affect many repos. |
…f the config_substitution data class when providing configuration substitution directives. We will go ahead and convert all relevant integtests to use attribution_substitution (or other new substitution classes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...such as when the replacement entity is a configuration object instead of just a simple value.
Description
These changes are needed to allow us to reduce duplication of sample configurations in
daqsystemtest/example-configs.The new functionality in this repo will allow us to specify more sophisticated configuration substitutions in our integtest files.
This PR is part of DUNE-DAQ/daq-deliverables#181.
Testing Suggestions
The changes in this PR can be tested and merged independently of any other changes, but follow-on changes in
daqsystemtest,asiolibs, andcrtmoduleswill depend on these changes. To test the backward-compatibility of these changes, one would simply install the modified code in a local software area (e.g.pip install -U .) and run existing regression tests.