Skip to content

Conversation

@bieryAtFnal
Copy link
Contributor

@bieryAtFnal bieryAtFnal commented Dec 29, 2025

Description

This PR is correlated with DUNE-DAQ/daqsystemtest#281.

Please note that with this change, the name of the current pytest will have the process manager type in it. For example, WIBEth_TPG_System-StandAloneSSH_PM. In the changes that I have made so far, I have chosen variable names and process-manager-type names that seem reasonable to me. I plan on discussing all of this with all interested people after the break, and if people suggest better names, I'm certainly open to such changes.

In a discussion with Pawel and a few other people from the CCM WG, I learned that they are thinking about integration/regression tests that validate the behavior of different types of run control process managers. This led to the request for the ability to specify one or more process manager types in our integtest files.

The changes in this PR are an initial step in this direction.

  • a very simple data structure was created to hold the name of the process manager type. This structure can be extended if/when we learn about any additional functionality that is needed.
  • a fixture was added to determine the process manager type and to support looping over different PM types
  • a default value for a single process manager type was added so that we don't need to immediately change all existing integtests. (a sample will be provided in daqsystemtest as part of these changes)

To test these changes, along with the corresponding ones in daqsystemtest, we can use the following steps:

DATE_PREFIX=`date '+%d%b'`
TIME_SUFFIX=`date '+%H%M'`

source /cvmfs/dunedaq.opensciencegrid.org/setup_dunedaq.sh
setup_dbt latest
dbt-create -n NFD_DEV_251229_A9 ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}
cd ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}/sourcecode

git clone https://github.com/DUNE-DAQ/daqsystemtest.git -b kbiery/multiple_procmgr_support
cd ..

dbt-workarea-env

git clone https://github.com/DUNE-DAQ/integrationtest.git -b kbiery/multiple_procmgr_support
cd integrationtest; pip install -U . ; cd ..

dbt-build -j 12
dbt-workarea-env

dbt-build --integtest daqsystemtest
echo ""
echo -e "\U1F535 \U2705 Note that all regression tests passed. \U2705 \U1F535"

Type of change

  • New feature or enhancement (non-breaking change which adds functionality)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas

Copy link
Member

@eflumerf eflumerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests still pass

@bieryAtFnal bieryAtFnal merged commit 8231691 into develop Dec 30, 2025
@bieryAtFnal bieryAtFnal deleted the kbiery/multiple_procmgr_support branch December 30, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants