Modernize, minimize, and cleanup containers #129
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eflumerf
approved these changes
Jan 2, 2026
Member
eflumerf
left a comment
eflumerf
left a comment
There was a problem hiding this comment.
Things look reasonable to me, however I do not have any kind of testing environment so I can't speak too much about functionality.
Contributor
Author
|
@copilot review this please |
jcpunk
force-pushed
the
modernize
branch
12 times, most recently
from
72b65f9 to
c8d8f52
Compare
jcpunk
force-pushed
the
modernize
branch
9 times, most recently
from
9e075dd to
28ce1ba
Compare
jcpunk
force-pushed
the
modernize
branch
2 times, most recently
from
6af162d to
284efa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot going on here.
I recommend reviewing the commits one at a time rather than the full diff as a blob.
In theory each commit is a rational step with clear self contained logic.
Copilot and coderabbit identified bits of code that probably never worked. These are probably bits that could be dropped, but that would require an expert to review.
To be clear, I really only care about the containers...