Enchanter Blacklisting System#822
Open
Shibva wants to merge 4 commits intoDaFuqs:1.20.1-aria-for-paintersfrom
Open
Enchanter Blacklisting System#822Shibva wants to merge 4 commits intoDaFuqs:1.20.1-aria-for-paintersfrom
Shibva wants to merge 4 commits intoDaFuqs:1.20.1-aria-for-paintersfrom
Conversation
- Added a new Enchantment tag and blacklist check for the Enchanter; Enchantment ids in the `enchanter_blacklisted_enchantments` tag will now be skipped for both enchanting processes. Will still work if the enchantment is on the central item already though. This will enable modpack makers and developers to restrict enchantments that are acquired though other means exclusively to their method.
- Duplicated `collectHighestEnchantments` with original functionality and refitted the second one to accept a `blacklist` arg to act as a exclusion filter. - Adjusted Enchanter to use the filterable version of `collectHighestEnchantments` with the `ENCHANTER_BLACKLIST` tag - Renamed the actual data tag from `blacklisted_enchantments` to `enchanter_copying_and_applying_blacklisted` as requested - add in a blank tag under Enchantment `enchanter_copying_and_applying_blacklisted` as requested by Daf, it will be empty but there to suggest its existence to those who crawl through mods looking for ways to configure stuff lol - Made a suggested adjustment by IDEA to simplify a part (see line 27 in SpectrumEnchantmentTags.java) - Client tested the workspace for the desired functionality after changes were made
- Did the same thing but with items now, only difference it only for the copying while the applying still works if its on the central item - The purpose of this is to restrict items that may come pre-enchanted if a modpack developer decides to restrict them (I figured id do this too while I was at it) - Copied and retooled the `isIn()` method in `SpectrumEnchantmentTags` for `SpectrumItemTags` (and it worked!) - Created a new blank tag named `enchanter_copying_and_applying_item_blacklisted`, empty by default - Tested it again EXTRA: Moved `Malum` Compat back under the connector restricted check due to differences throwing NoSuchField errors (thanks Farbicators of Create Porting Lib >:L )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #821