Skip to content

Conversation

@lambrojos
Copy link
Contributor

A customer asked for the possiblity to see date formats, and so I had to customize the library. I'm sending this pr to ask if maybe you want to integrate this feature as well

}
Util.inherits(XlsxStreamReaderWorkSheet, Stream)

const tryFormat = function (format, workingVal) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to refactor a bit, complexity is beginning to pile up in the formatting code

@krutijan1
Copy link

Hi @lambrojos , I have same problem as you, tried to fork your repository and install master branch, also show-formats, but it fills formats with undefined or <1 empty item>, right now the library is parsing date as 1904 time format, can I somehow make this work ?

Thanks

@brunoargolo
Copy link
Contributor

Hi @krutijan1 ,

I just submitted a PR for adding support to 1904 date format.
Not sure if this will solve your issue but you can take a look.

@lambrojos
Copy link
Contributor Author

Hi @krutijan1 sorry for the very late answer.
Yes I found myself in trouble too with date formats and as I could not wait for PRs in here to be approved I found myself forced to incorporate xlsx-stream-reader in my own library https://www.npmjs.com/package/supersalmon.

I fixed this and other parsing corner cases in there. If you want to take a look code or backport the code: https://github.com/lambrojos/supersalmon/blob/master/lib/worksheet.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants