Sourcery refactored main branch by sourcery-ai[bot] · Pull Request #66 · DaTiC0/smart-google

sourcery-ai · 2023-03-28T06:47:21Z

Branch main refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the main branch, then run:

git fetch origin sourcery/main
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai · 2023-03-28T06:47:23Z

ReportState.py

    url = 'https://accounts.google.com/o/oauth2/token'
    headers = {'Content-Type': 'application/x-www-form-urlencoded'}
-    data = 'grant_type=urn%3Aietf%3Aparams%3Aoauth%3Agrant-type%3Ajwt-bearer&assertion=' + signed_jwt
+    data = f'grant_type=urn%3Aietf%3Aparams%3Aoauth%3Agrant-type%3Ajwt-bearer&assertion={signed_jwt}'


Function get_access_token refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2023-03-28T06:47:23Z

ReportState.py

-    headers = {
-        'X-GFE-SSL': 'yes',
-        'Authorization': 'Bearer ' + access_token
-    }
+    headers = {'X-GFE-SSL': 'yes', 'Authorization': f'Bearer {access_token}'}
    data = report_state_file
    response = requests.post(url, headers=headers, json=data)
-    print('Response: ' + response.text)
+    print(f'Response: {response.text}')


Function report_state refactored with the following changes:

Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

sourcery-ai · 2023-03-28T06:47:23Z

ReportState.py

-    success = report_state(access_token, report_state_file)
-
-    if success:
+    if success := report_state(access_token, report_state_file):


Function main refactored with the following changes:

Use named expression to simplify assignment and conditional (use-named-expression)

sourcery-ai · 2023-03-28T06:47:24Z

action_devices.py

            "id": k,
        }
-        DEVICE.update(v)
+        DEVICE |= v


Function rsync refactored with the following changes:

Merge dictionary updates via the union operator (dict-assign-update-to-union)

sourcery-ai · 2023-03-28T06:47:24Z

action_devices.py

        for device in i['payload']['devices']:
            deviceId = device['id']
-            print('DEVICE ID: ' + deviceId)
+            print(f'DEVICE ID: {deviceId}')


Function onQuery refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2023-03-28T06:47:26Z

notifications.py

-    print('Published message with mid {}.'
-          .format(mid))
+    print(f'Published message with mid {mid}.')


Function handle_publish refactored with the following changes:

Replace call to format with f-string (use-fstring-for-formatting)

sourcery-ai · 2023-03-28T06:47:26Z

notifications.py

-    print('Subscription id {} granted with qos {}.'
-          .format(mid, granted_qos))
+    print(f'Subscription id {mid} granted with qos {granted_qos}.')


Function handle_subscribe refactored with the following changes:

Replace call to format with f-string (use-fstring-for-formatting)

sourcery-ai · 2023-03-28T06:47:26Z

notifications.py

-    print('Received message on topic {}: {}'
-          .format(message.topic, message.payload.decode()))
+    print(f'Received message on topic {message.topic}: {message.payload.decode()}')


Function handle_mytopic refactored with the following changes:

Replace call to format with f-string (use-fstring-for-formatting)

sourcery-ai · 2023-03-28T06:47:27Z

notifications.py

-    print('Received message on topic {}: {}'
-          .format(message.topic, message.payload.decode()))
+    print(f'Received message on topic {message.topic}: {message.payload.decode()}')


Function handle_ztopic refactored with the following changes:

Replace call to format with f-string (use-fstring-for-formatting)

sourcery-ai · 2023-03-28T06:47:27Z

routes.py

    print("this is authorize")
    user = get_current_user()
-    print("Authorize User: %s" % user)
+    print(f"Authorize User: {user}")


Function authorize refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-03-28T06:47:28Z

Sourcery Code Quality Report

❌ Merging this PR will decrease code quality in the affected files by 0.55%.

Quality metrics	Before	After	Change
Complexity	1.75 ⭐	1.77 ⭐	0.02 👎
Method Length	44.71 ⭐	44.71 ⭐	0.00
Working memory	6.55 🙂	6.69 🙂	0.14 👎
Quality	80.24% ⭐	79.69% ⭐	-0.55% 👎

Other metrics	Before	After	Change
Lines	489	468	-21

Changed files	Quality Before	Quality After	Quality Change
ReportState.py	83.87% ⭐	83.70% ⭐	-0.17% 👎
action_devices.py	76.18% ⭐	76.22% ⭐	0.04% 👍
app.py	67.44% 🙂	67.53% 🙂	0.09% 👍
auth.py	79.92% ⭐	79.30% ⭐	-0.62% 👎
generate_service_account_file.py	84.75% ⭐	84.63% ⭐	-0.12% 👎
models.py	94.86% ⭐	94.17% ⭐	-0.69% 👎
notifications.py	88.57% ⭐	88.42% ⭐	-0.15% 👎
routes.py	82.85% ⭐	82.80% ⭐	-0.05% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
action_devices.py	actions	7 ⭐	112 🙂	12 😞	56.87% 🙂	Extract out complex expressions
action_devices.py	commands	6 ⭐	100 🙂	12 😞	59.44% 🙂	Extract out complex expressions
routes.py	authorize	2 ⭐	111 🙂	10 😞	65.54% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

'Refactored by Sourcery'

78746bc

sourcery-ai bot requested a review from DaTiC0 March 28, 2023 06:47

sourcery-ai bot commented Mar 28, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sourcery refactored main branch#66

Sourcery refactored main branch#66
sourcery-ai[bot] wants to merge 1 commit intomainfrom
sourcery/main

sourcery-ai bot commented Mar 28, 2023

Uh oh!

sourcery-ai bot Mar 28, 2023

Uh oh!

sourcery-ai bot Mar 28, 2023

Uh oh!

sourcery-ai bot Mar 28, 2023

Uh oh!

sourcery-ai bot Mar 28, 2023

Uh oh!

sourcery-ai bot Mar 28, 2023

Uh oh!

sourcery-ai bot Mar 28, 2023

Uh oh!

sourcery-ai bot Mar 28, 2023

Uh oh!

sourcery-ai bot Mar 28, 2023

Uh oh!

sourcery-ai bot Mar 28, 2023

Uh oh!

sourcery-ai bot Mar 28, 2023

Uh oh!

sourcery-ai bot commented Mar 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

Conversation

sourcery-ai bot commented Mar 28, 2023

Uh oh!

sourcery-ai bot Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot commented Mar 28, 2023

Sourcery Code Quality Report

Legend and Explanation

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants