Fix MQTT message payload comparison

[DaTiC0]

Summary

• correct MQTT message payload decoding in notification handler

Testing

• pytest -q

---

https://chatgpt.com/codex/tasks/task_e_68420ac00b888327a2289f2cb31b65d5

Summary by Sourcery

Bug Fixes:

• Compare decoded payload string instead of the message object in the MQTT notification handler

[sourcery-ai]

Reviewer's Guide

Adjust MQTT notification handler to properly decode the message payload before comparing to a string literal.

File-Level Changes

Change	Details	Files
Fix MQTT message payload comparison	Replace direct message object comparison with decoded payload comparison	notifications.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @DaTiC0 - I've reviewed your changes - here's some feedback:

• Extract message.payload.decode() into a local variable to avoid multiple decodings and improve readability.
• Switch to a logging framework instead of print() for better log management and severity levels.
• Consider handling potential decoding errors (e.g. non-UTF-8 payloads) by wrapping decode() in try/except or using fallback options.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion: Avoid decoding payload multiple times

Decode the payload once into a variable and reuse it for both printing and comparison to improve readability and efficiency.