Skip to content

Fix remember me checkbox#81

Merged
DaTiC0 merged 1 commit intomainfrom
codex/add-remember-checkbox-to-login-form
Jun 6, 2025
Merged

Fix remember me checkbox#81
DaTiC0 merged 1 commit intomainfrom
codex/add-remember-checkbox-to-login-form

Conversation

@DaTiC0
Copy link
Owner

@DaTiC0 DaTiC0 commented Jun 6, 2025

Summary

  • add name="remember" to the checkbox in login template
  • login route already reads this value

Testing

  • pytest -q

https://chatgpt.com/codex/tasks/task_e_6842ba4452e4832792a1ecbe64572c52

Summary by Sourcery

Bug Fixes:

  • Add name="remember" to the login form checkbox to ensure the option is included in form data

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 6, 2025

Reviewer's Guide

Adds the name="remember" attribute to the login form checkbox so the server can detect and process the remember-me option.

File-Level Changes

Change Details Files
Enable server-side processing of the remember-me checkbox
  • Added name="remember" attribute to the checkbox input in the login form.
templates/login.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DaTiC0 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@DaTiC0
Copy link
Owner Author

DaTiC0 commented Jun 6, 2025

ok

Copy link
Owner Author

@DaTiC0 DaTiC0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@DaTiC0 DaTiC0 merged commit 07acedb into main Jun 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant