Support bookworm and alpine image #379
Merged
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@dheeg Walk me through this a little better. Since there's no shell script being referenced. How does this behave in the same way? |
Contributor
Author
|
@DandyDeveloper The split-brain-fix container executes "sh /readonly-config/fix-split-brain.sh", see https://github.com/DandyDeveloper/charts/blob/master/charts/redis-ha/templates/redis-ha-statefulset.yaml#L490 So in the future both have to be aligned, but this kind of was also the case before. |
Owner
|
@dheeg Oh, for whatever reason, I completely forgot what pgrep was doing here. I understand the change. Approving. I'll merge when CI finishes. |
DandyDeveloper
previously approved these changes
Jan 26, 2026
Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com>
DandyDeveloper
previously approved these changes
Jan 26, 2026
DandyDeveloper
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #376 the chart doesn't support the upstream bookworm image out of the box at the moment. The readiness probe for the
split-brain-fixcontainer fails on bookworm, becausepgrepis not available.Since
pidofis available for both, it could be used as default.