Make it compatible with Chocolatey#42
Open
KoltesDigital wants to merge 2 commits intoDaniel15:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried to use this project for hosting Chocolatey packages. It's almost good, but some requests were failing due to complex filters that are not handled yet. Specifically,
choco info package-nameleads to the following request:Although this filter could have been parsed with a regex, I preferred to generate a parser, so that it could easily be enhanced later if needed. The generator is to be found here (PR adds mention in the README).
With this PR, the above request is successfully parsed and the response is as expected.