Refactor AsyncOperation to use _name property and implement git/foldername prefix#17
Draft
Refactor AsyncOperation to use _name property and implement git/foldername prefix#17
Conversation
…rname prefix Co-authored-by: eh-main-bot <171766998+eh-main-bot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor meta operation class to use _name property and update name logic
Refactor AsyncOperation to use _name property and implement git/foldername prefix
Jun 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 94.65% 94.69% +0.03%
==========================================
Files 29 29
Lines 599 603 +4
==========================================
+ Hits 567 571 +4
Misses 32 32 ☔ View full report in Codecov by Sentry. |
Collaborator
|
@copilot update branch |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
AsyncOperationbase class to improve encapsulation and provide more descriptive operation names by implementing the requirements outlined in the issue.Changes Made
Base Class Refactoring
nameto_namein theAsyncOperationbase classnameproperty: Returnsgit/{foldername}/{_name}format wherefoldernameis the root git repository directory name_nameproperty is now the internal implementation detail that subclasses overrideSubclass Updates
Updated all 14 subclasses to use
_nameinstead ofname:CreateDirOperation,EditFileOperation,MoveDirOperation,RemoveFileOperation,RenameOperationGitAddOperation,GitCheckoutOperation,GitCommitOperation,GitCreateBranchOperation,GitDiffOperation,GitPullOperation,GitPushOperation,GitStatusOperationExecMakeTarget,PredefinedCommandsTest Updates
tool.name.endswith("/git_status"))Example
Before:
After:
Benefits
_name) and public (name) interfacesTesting
Fixes #14.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.