Skip to content

Update rust.yml#27

Merged
Dargon789 merged 1 commit intomasterfrom
Dargon789-patch-2
Oct 2, 2025
Merged

Update rust.yml#27
Dargon789 merged 1 commit intomasterfrom
Dargon789-patch-2

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Oct 2, 2025

Summary by Sourcery

Simplify the GitHub Actions Rust workflow by removing the default build and test steps and adding a release-mode build step for the gbt crate

Enhancements:

  • Replace the general build and test steps with a targeted release build for the gbt crate

CI:

  • Update rust.yml to run a single cargo build --release using --manifest-path rust/gbt/Cargo.toml

Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 2, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactor CI workflow in rust.yml to streamline Rust build steps by consolidating build and test into a single release build targeting a specific crate, and adjust the working directory accordingly.

Flow diagram for streamlined Rust build process in CI

flowchart TD
    Start(["Start Workflow"]) --> Checkout(["actions/checkout@v4"])
    Checkout --> Build(["cargo build --release --manifest-path rust/gbt/Cargo.toml"])
    Build --> End(["End Workflow"])
Loading

File-Level Changes

Change Details Files
Consolidate build and test into a single Cargo release build step
  • Removed separate ‘Build’ step with verbose build at project root
  • Removed separate ‘Run tests’ step with verbose test at project root
  • Added ‘Build with Cargo’ step using cargo build --release with explicit manifest path
  • Updated working-directory to rust/gbt
.github/workflows/rust.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • You removed the cargo test step—consider re-adding a cargo test --manifest-path rust/gbt/Cargo.toml step to ensure tests still run in CI.
  • To speed up your workflow, add cargo dependency caching (e.g. using actions/cache@v3) before the build step.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- You removed the `cargo test` step—consider re-adding a `cargo test --manifest-path rust/gbt/Cargo.toml` step to ensure tests still run in CI.
- To speed up your workflow, add cargo dependency caching (e.g. using actions/cache@v3) before the build step.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Dargon789 Dargon789 merged commit db2d909 into master Oct 2, 2025
21 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-2 branch October 2, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant