Skip to content

Update e2e_parameterized.yml#40

Merged
Dargon789 merged 1 commit intomasterfrom
Dargon789-patch-2
Oct 2, 2025
Merged

Update e2e_parameterized.yml#40
Dargon789 merged 1 commit intomasterfrom
Dargon789-patch-2

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Oct 2, 2025

Summary by Sourcery

Update the E2E parameterized GitHub Actions workflow to include test spec patterns and adjust the npm start command formatting

CI:

  • Add a new matrix axis 'spec' listing Cypress spec file globs for mainnet, signet, mainnet2, and liquid2
  • Adjust the 'npm run start:parameterized' commands to use a space after the colon for consistency

Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 2, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enhances the e2e_parameterized CI workflow by introducing a new matrix dimension to group Cypress spec files and standardizing the npm start invocation for parameterized test runs.

File-Level Changes

Change Details Files
Added a spec matrix dimension to parameterize Cypress test runs
  • Introduced a 'spec' field under the matrix configuration
  • Defined grouped spec patterns for mainnet, signet, mainnet2, and liquid2
.github/workflows/e2e_parameterized.yml
Updated npm start command formatting for parameterized tests
  • Replaced 'npm run start:parameterized' with 'npm run start: parameterized' in all job definitions
.github/workflows/e2e_parameterized.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The new spec field under the matrix is misaligned and uses an inconsistent YAML literal; align it properly under strategy.matrix and use a correct list syntax so the matrix parser can pick it up.
  • You’ve accidentally added a space in npm run start: parameterized; it should remain npm run start:parameterized to correctly match your npm script name.
  • Although you added a spec matrix entry, the workflow steps don’t reference matrix.spec; make sure you pass that variable into your Cypress invocation so the correct tests actually run.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new `spec` field under the matrix is misaligned and uses an inconsistent YAML literal; align it properly under `strategy.matrix` and use a correct list syntax so the matrix parser can pick it up.
- You’ve accidentally added a space in `npm run start: parameterized`; it should remain `npm run start:parameterized` to correctly match your npm script name.
- Although you added a `spec` matrix entry, the workflow steps don’t reference `matrix.spec`; make sure you pass that variable into your Cypress invocation so the correct tests actually run.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Dargon789 Dargon789 merged commit d4d4db3 into master Oct 2, 2025
14 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-2 branch October 2, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant