Skip to content

Update rust.yml#49

Merged
Dargon789 merged 1 commit intomasterfrom
Dargon789-patch-2
Oct 15, 2025
Merged

Update rust.yml#49
Dargon789 merged 1 commit intomasterfrom
Dargon789-patch-2

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Oct 15, 2025

Summary by Sourcery

CI:

  • Remove explicit runner specification and steps wrapper in Rust workflow and embed cargo build command with working-directory at the job level

Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 15, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refactors the Rust CI workflow by removing the default runner setting and introducing an explicit build command scoped to the rust directory

File-Level Changes

Change Details Files
Removed default GitHub Actions runner
  • Deleted runs-on: ubuntu-latest
  • Removed stray blank line
.github/workflows/rust.yml
Added explicit Cargo build invocation and working directory
  • Inserted run: cargo build --release --manifest-path rust/Cargo.toml
  • Added working-directory: rust
.github/workflows/rust.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link

snyk-io bot commented Oct 15, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Jobs in GitHub Actions require a 'runs-on' specification; make sure to restore it under the build job.
  • The 'run' and 'working-directory' keys should be part of a step rather than at the job level; consider nesting them under a 'steps' entry.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Jobs in GitHub Actions require a 'runs-on' specification; make sure to restore it under the build job.
- The 'run' and 'working-directory' keys should be part of a step rather than at the job level; consider nesting them under a 'steps' entry.

## Individual Comments

### Comment 1
<location> `.github/workflows/rust.yml:17` </location>
<code_context>

-    runs-on: ubuntu-latest
-
+  run: cargo build --release --manifest-path rust/Cargo.toml
+  working-directory: rust
     steps:
</code_context>

<issue_to_address>
**issue (bug_risk):** The 'run' and 'working-directory' keys are misplaced in the workflow job definition.

These keys must be placed inside a step to ensure the workflow parses and runs correctly. Please update the job definition accordingly.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Dargon789 Dargon789 merged commit 7a481e8 into master Oct 15, 2025
15 of 16 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-2 branch October 15, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant