Skip to content

Update ci.yml#50

Merged
Dargon789 merged 1 commit intomasterfrom
Dargon789-patch-2
Oct 15, 2025
Merged

Update ci.yml#50
Dargon789 merged 1 commit intomasterfrom
Dargon789-patch-2

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Oct 15, 2025

Summary by Sourcery

Streamline CI pipeline by removing manual caching steps and redundant matrix configuration

Enhancements:

  • Remove redundant matrix strategy under cache assets job

CI:

  • Drop custom actions/cache steps for npm modules in backend, frontend, and e2e jobs
  • Remove custom Rust dependency caching

Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 15, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Simplify ci.yml by removing npm and Rust caching steps and cleaning up cache job configuration to streamline the CI pipeline.

Flow diagram for simplified CI pipeline process

flowchart TD
  A["Code pushed or PR opened"] --> B["CI Workflow Triggered"]
  B --> C["Checkout Repository"]
  C --> D["Setup Node.js"]
  D --> E["Setup Rust Toolchain (if needed)"]
  E --> F["Install Dependencies"]
  F --> G["Build/Run Jobs (Backend, Frontend, E2E, Cache)"]
  G --> H["Complete CI Pipeline"]

  %% No explicit cache restore/save steps for npm or Rust
Loading

File-Level Changes

Change Details Files
Eliminate npm caching configuration
  • Dropped 'cache' and 'cache-dependency-path' options from setup-node invocations for backend, frontend, and e2e jobs
  • Removed standalone actions/cache steps for node_modules in backend, frontend, and e2e
.github/workflows/ci.yml
Remove Rust dependencies cache step
  • Deleted actions/cache step for Rust registry, git, and target directories as part of the GBT workflow
.github/workflows/ci.yml
Simplify CI cache job configuration
  • Removed matrix strategy defining node versions under the cache assets job
.github/workflows/ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link

snyk-io bot commented Oct 15, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • By removing the explicit actions/cache steps for Node and Rust, build performance might regress—please confirm that setup-node’s built-in caching covers all dependencies or consider consolidating cache logic at the workflow level.
  • The deletion of the matrix-based cache strategy in the assets build could impact frontend and e2e build speeds—ensure there’s a unified caching approach in place to maintain CI performance.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- By removing the explicit actions/cache steps for Node and Rust, build performance might regress—please confirm that setup-node’s built-in caching covers all dependencies or consider consolidating cache logic at the workflow level.
- The deletion of the matrix-based cache strategy in the assets build could impact frontend and e2e build speeds—ensure there’s a unified caching approach in place to maintain CI performance.

## Individual Comments

### Comment 1
<location> `.github/workflows/ci.yml:49-58` </location>
<code_context>
         run: echo "::set-output name=toolchain::$(cat ./rust/gbt/rust-toolchain)"
         working-directory: ${{ matrix.node }}/${{ matrix.flavor }}

-      - name: Cache Rust dependencies
-        uses: actions/cache@v4
-        with:
-          path: |
-            ~/.cargo/bin/
-            ~/.cargo/registry/index/
-            ~/.cargo/registry/cache/
-            ~/.cargo/git/db/
-            ${{ matrix.node }}/${{ matrix.flavor }}/rust/gbt/target/
-          key: ${{ runner.os }}-cargo-${{ matrix.flavor }}-${{ hashFiles('${{ matrix.node }}/${{ matrix.flavor }}/rust/gbt/**/Cargo.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-cargo-${{ matrix.flavor }}-
-            ${{ runner.os }}-cargo-
-
       - name: Install ${{ steps.gettoolchain.outputs.toolchain }} Rust toolchain
</code_context>

<issue_to_address>
**suggestion (performance):** Removing Rust dependency caching may slow down Rust builds.

Without caching, CI runs may become slower due to repeated downloads and builds. If this change is intentional, monitor build times and consider restoring caching if performance issues arise.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Dargon789 Dargon789 merged commit 3009aee into master Oct 15, 2025
15 of 16 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-2 branch October 15, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant