Fix dataset undefined values and selection hover bug#456
Open
Fix dataset undefined values and selection hover bug#456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves user interface feedback and strengthens dataset data validation.
It fixes an issue where newly uploaded datasets displayed
undefinedvalues due to missingtotal_rowsandtotal_columnsduring dataset merging. Additionally, it improves selection highlighting behavior so that selected items keep their background color when hovered, ensuring consistent visual feedback.Type of Change
Check all that apply like this [x]:
Changes (by file)
ItemBox.jsx: Updated hover background color logic to preserve the selected color when an item is hovered while selected; otherwise, the hover color is applied.useDatasets.js: Added validation checks to ensuretotal_rowsandtotal_columnsexist before merging dataset information, preventingundefinedvalues for newly uploaded datasets.Testing (optional)
total_rowsandtotal_columnsare displayed correctly (noundefinedvalues).