Fix icons in README by using old version as source#18
Fix icons in README by using old version as source#18sebkur wants to merge 1 commit intoDatL4g:masterfrom
Conversation
The Windows icon has been removed in a recent version of simple icons, but it can still be obtained from older versions of the library on some of the CDNs.
|
This is a workaround for this: simple-icons/simple-icons#10019 |
DatL4g
left a comment
There was a problem hiding this comment.
This sources do not support dark mode, which is widely used on GitHub.
Are there white/black equivalents? Then we could specify these by attribute.
|
Oh, I didn't realize that feature of simple-icons own CDN was in use here. Hmm, unfortunately, the other CDNs don't seem to support this. Thinking about other workarounds, but cannot seem to find any at the moment. Sorry, don't have a solution for this then, feel free to close... |
|
I've been looking around a bit and found out that there are ways to include html in github markdown and it's even possible to select images based on the dark/light theme: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to So it's possible to exchange the image based on theme, here's some experimental code: sebkur@c4418d9 visible at https://github.com/sebkur/KCEF/tree/fix-icons2 In the example for the sake of trying things out, I'm using the windows icon for light mode and the linux icon for dark mode. That works. So if we had a source of each image with white fill, we could swap them out based on the theme. But that's the problem of course, we don't have that... It's interesting though, the SVG files don actually specify an fill color, so they default to black. It's even possible to use some css in the embedded html, however it does not look like we can manipulate the svg coloring from the embedding html. |

The Windows icon has been removed in a recent version of simple icons, but it can still be obtained from older versions of the library on some of the CDNs.