Conversation
melissachang
left a comment
There was a problem hiding this comment.
Do single quotes work?
If single quotes work, let's revert this PR
|
But double-quotes should work too. Though it doesn't make sense to me that these would be different? The flag parsing library should be providing the underlying value regardless? |
Just tested it with the ssh command and it doesn't appear to work. The dsub example doesn't work as expected either. |
|
Good point that double quotes should work, and that flag-parsing library (picocli) should handle this. https://stackoverflow.com/questions/63629789/how-to-escape-chars-from-string-option Is it possible to write a test that fails before this PR and passes after this PR? |
|
Kudos, SonarCloud Quality Gate passed!
|








Previously, running a command like
terra gcloud compute ssh --zone us-central1-a jupyter@newenv --command "ps aux"would fail to parse, as the space information in the quoted part would be lost when the command is built.