-
Notifications
You must be signed in to change notification settings - Fork 166
⚗️ [RUM-13259]Track action names in shadow dom #4044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: ce2bd06 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Works perfectly with the html test you sent me.
Looks good in the explorer UI too
| }) | ||
| }) | ||
|
|
||
| describe('shadow DOM support', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 suggestion: Could be nice to also test privacy settings with shadow dom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea ! I added one 👍
| * @category Beta | ||
| * @defaultValue false | ||
| */ | ||
| betaTrackActionsInShadowDom?: boolean | undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 thought: I don’t think we need the beta prefix. IMO, the implementation is not too complex to justify it.
I recommend putting the feature behind a feature flag so we can easily enable or disable it during dogfooding.
Motivation
Clicks inside Shadow DOM components currently result in imprecise action names because event.target is retargeted to the shadow host.
Changes
This PR adds experimental support for extracting accurate action names from elements inside Shadow DOM
This is the first phase of Shadow DOM support, focusing on action names only. Selector tracking inside Shadow DOM will be added in a follow-up PR. This feature is experimental and gated behind the betaTrackActionsInShadowDom opt-in parameter.
Test instructions
Checklist