Skip to content

Conversation

@thomas-lebeau
Copy link
Collaborator

@thomas-lebeau thomas-lebeau commented Jan 15, 2026

Motivation

The deploy-minor-dc job fails consistently, with a ECONNRESET error to the call of the logs API (checkTelemetryErrors())

Interestingly, checkTelemetryErrors() is called successfully before the deploy and source-maps upload scripts, but not after. This leads us to think this might be due to a connexion pool exhaustion issue.

Unfortunately, I'm not able to reproduce the failing outside of the release.

Changes

Integrate 'undici' HTTP agent in checkTelemetryErrors(), enforcing a new connexion pool is used at each call.

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

…ment script, enhancing connection management and error handling during telemetry checks.
@datadog-official
Copy link

datadog-official bot commented Jan 15, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 77.29% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: df7281c | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jan 15, 2026

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 164.36 KiB 164.36 KiB 0 B 0.00%
Rum Profiler 4.33 KiB 4.33 KiB 0 B 0.00%
Rum Recorder 24.48 KiB 24.48 KiB 0 B 0.00%
Logs 56.14 KiB 56.14 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 121.57 KiB 121.57 KiB 0 B 0.00%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.005 0.0042 -16.00%
RUM - add action 0.0188 0.012 -36.17%
RUM - add error 0.0122 0.0117 -4.10%
RUM - add timing 0.0032 0.0027 -15.63%
RUM - start view 0.0035 0.0035 0.00%
RUM - start/stop session replay recording 0.0008 0.0007 -12.50%
Logs - log message 0.0155 0.0136 -12.26%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 25.94 KiB 28.02 KiB +2.09 KiB
RUM - add action 49.39 KiB 51.83 KiB +2.44 KiB
RUM - add timing 25.10 KiB 25.10 KiB -2 B
RUM - add error 53.99 KiB 55.93 KiB +1.94 KiB
RUM - start/stop session replay recording 23.79 KiB 25.93 KiB +2.15 KiB
RUM - start view 423.43 KiB 425.28 KiB +1.85 KiB
Logs - log message 92.21 KiB 49.34 KiB -42.87 KiB

🔗 RealWorld

@thomas-lebeau thomas-lebeau marked this pull request as ready for review January 16, 2026 08:12
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner January 16, 2026 08:12
dev,tsconfig-paths-webpack-plugin,MIT,Copyright 2016 Jonas Kello
dev,typescript,Apache-2.0,Copyright Microsoft Corporation
dev,typescript-eslint,MIT,Copyright (c) 2019 typescript-eslint and other contributors
dev,undici,MIT,Copyright (c) Matteo Collina and Undici contributors
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added this one, the other one I just reorder them alphabetically for conveniance.

@thomas-lebeau thomas-lebeau merged commit fd73d9e into main Jan 16, 2026
21 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/deploy-auto-connexion-pool branch January 16, 2026 09:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants