-
Notifications
You must be signed in to change notification settings - Fork 166
👷 manage checkTelemetryError connexion pool #4094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment script, enhancing connection management and error handling during telemetry checks.
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: df7281c | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
thomas-lebeau
commented
Jan 16, 2026
| dev,tsconfig-paths-webpack-plugin,MIT,Copyright 2016 Jonas Kello | ||
| dev,typescript,Apache-2.0,Copyright Microsoft Corporation | ||
| dev,typescript-eslint,MIT,Copyright (c) 2019 typescript-eslint and other contributors | ||
| dev,undici,MIT,Copyright (c) Matteo Collina and Undici contributors |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added this one, the other one I just reorder them alphabetically for conveniance.
rgaignault
approved these changes
Jan 16, 2026
BenoitZugmeyer
approved these changes
Jan 16, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The deploy-minor-dc job fails consistently, with a
ECONNRESETerror to the call of the logs API (checkTelemetryErrors())Interestingly,
checkTelemetryErrors()is called successfully before the deploy and source-maps upload scripts, but not after. This leads us to think this might be due to a connexion pool exhaustion issue.Unfortunately, I'm not able to reproduce the failing outside of the release.
Changes
Integrate 'undici' HTTP agent in
checkTelemetryErrors(), enforcing a new connexion pool is used at each call.Test instructions
Checklist