Skip to content

Conversation

@rgaignault
Copy link
Contributor

@rgaignault rgaignault commented Jan 16, 2026

Motivation

Second part of shadow DOM support for actions. This PR adds selector generation for elements inside shadow DOM, using a /shadow/ marker to indicate shadow boundaries.
Follows up on the first PR that added action name support.

Changes

  • Generate selectors that cross shadow DOM boundaries with /shadow/ marker
  • Added unit tests for shadow DOM selectors
  • Added e2e tests for selector generation

These two pictures are coming from the same click with and without the parameter enabled. The selector is correct and more precise that's why the width and height are smaller.

Before

image

After

image

Selector query

image

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@rgaignault rgaignault requested a review from a team as a code owner January 16, 2026 14:13
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ccb1ca4218

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jan 16, 2026

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 164.92 KiB 165.11 KiB +196 B +0.12%
Rum Profiler 4.33 KiB 4.33 KiB 0 B 0.00%
Rum Recorder 24.48 KiB 24.48 KiB 0 B 0.00%
Logs 56.14 KiB 56.14 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 122.15 KiB 122.34 KiB +196 B +0.16%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.004 0.0044 +10.00%
RUM - add action 0.012 0.0142 +18.33%
RUM - add error 0.0114 0.0153 +34.21%
RUM - add timing 0.0026 0.0031 +19.23%
RUM - start view 0.0032 0.0031 -3.13%
RUM - start/stop session replay recording 0.0007 0.0007 0.00%
Logs - log message 0.0133 0.0131 -1.50%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 27.38 KiB 26.67 KiB -721 B
RUM - add action 52.43 KiB 50.87 KiB -1.55 KiB
RUM - add timing 26.06 KiB 25.78 KiB -294 B
RUM - add error 57.57 KiB 56.30 KiB -1.27 KiB
RUM - start/stop session replay recording 26.09 KiB 24.39 KiB -1.70 KiB
RUM - start view 427.23 KiB 425.71 KiB -1.52 KiB
Logs - log message 99.40 KiB 43.96 KiB -55.44 KiB

🔗 RealWorld

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 16, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 74.19%
Overall Coverage: 77.24% (-0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 81b3fd0 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants