build(prof): Fix bindgen compatibility with PHP 8.5.1+ on macOS #3583
+11
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When compiling the profiler on macOS with Homebrew Clang >= 19, bindgen fails with:
PHP 8.5.0 introduced the TAILCALL VM, a performance optimization that uses
__attribute__((preserve_none))for opcode handler function pointers. This is enabled when compiling PHP with a compiler that supports thepreserve_noneattribute (Clang >= 19) on x86_64 or aarch64.The problem is that bindgen does not support
CXCallingConv_PreserveNone(calling convention 20) and panics when parsing PHP headers containing these typedefs (zend_vm_opcode_handler_t,zend_vm_opcode_handler_func_tin our case).Reviewer checklist