[SDTEST-2703] Set default parallelism to number of available CPUs #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmarchenko
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e01ce6880d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
When a user only sets --max-parallelism to a lower value (e.g., 1), they should get that value, not the default min (which is now NumCPU). Previously, if max < min, the code returned min, effectively ignoring the user's cap. Now we clamp min to max instead, ensuring the user's explicit max setting takes precedence.
gnufede
approved these changes
Jan 30, 2026
anmarchenko
deleted the
anmarchenko/default_parallelism_is_number_of_cpus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--min-parallelismand--max-parallelismfrom1to the number of available CPUs (runtime.NumCPU())Motivation
Having parallelism set to 1 by default is not terribly useful for a parallel test runners: the number of available CPUs is more sensible default as we assume that we'll run tests in parallel on the current machine.
Test plan
make test)make lint)