Skip to content

Comments

Fix oci_blob to allow for blobs with size > max(i32)#104

Merged
bcmyers merged 1 commit intomainfrom
brian.myers/251031/i32
Oct 31, 2025
Merged

Fix oci_blob to allow for blobs with size > max(i32)#104
bcmyers merged 1 commit intomainfrom
brian.myers/251031/i32

Conversation

@bcmyers
Copy link
Contributor

@bcmyers bcmyers commented Oct 31, 2025

Attributes of type attr.int in bazel are limited to max(i32). We use that to record the size of blobs. That means rules_oci doesn't support blobs greater than 2,147,483,647 bytes in size, which is sad.

This PR converts the size attribute on oci_blob to be an attr.string instead so that we can use arbitrarily-sized integer values.

We also had to change the name of the attribute from size to size_ because an attribute named size in bazel is special and is only allowed to be of type attr.int

Copy link
Contributor Author

bcmyers commented Oct 31, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bcmyers bcmyers force-pushed the brian.myers/251031/i32 branch from d67a115 to 5e31591 Compare October 31, 2025 17:13
@bcmyers bcmyers force-pushed the brian.myers/251031/i32 branch from 5e31591 to 361cfeb Compare October 31, 2025 17:31
@bcmyers bcmyers marked this pull request as ready for review October 31, 2025 17:32
@bcmyers bcmyers merged commit 7e697cb into main Oct 31, 2025
3 checks passed
@bcmyers bcmyers deleted the brian.myers/251031/i32 branch October 31, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants