Fix oci_blob to allow for blobs with size > max(i32)#104
Merged
Conversation
d67a115 to
5e31591
Compare
5e31591 to
361cfeb
Compare
BryceBeagle
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Attributes of type
attr.intin bazel are limited tomax(i32). We use that to record thesizeof blobs. That meansrules_ocidoesn't support blobs greater than2,147,483,647bytes in size, which is sad.This PR converts the
sizeattribute onoci_blobto be anattr.stringinstead so that we can use arbitrarily-sized integer values.We also had to change the name of the attribute from
sizetosize_because an attribute namedsizein bazel is special and is only allowed to be of typeattr.int