Set OCI base image annotations for image built with oci_image#49
Open
abayer wants to merge 1 commit intoDataDog:mainfrom
Open
Set OCI base image annotations for image built with oci_image#49abayer wants to merge 1 commit intoDataDog:mainfrom
oci_image#49abayer wants to merge 1 commit intoDataDog:mainfrom
Conversation
This will enable a future change to `oci_rebase_image`, allowing that rule to automatically detect the old base image to replace from the original image's annotations, as well as any other tooling within rules_oci or consuming images built with `oci_image` to leverage the OCI base image annotations. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will enable a future change to
oci_rebase_image, allowing that rule to automatically detect the old base image to replace from the original image's annotations, as well as any other tooling within rules_oci or consuming images built withoci_imageto leverage the OCI base image annotations.cc @jprobinson