add formatting tests for go, markdown and yaml#78
Open
bcmyers wants to merge 1 commit intobrian.myers/241230/miscfrom
Open
add formatting tests for go, markdown and yaml#78bcmyers wants to merge 1 commit intobrian.myers/241230/miscfrom
bcmyers wants to merge 1 commit intobrian.myers/241230/miscfrom
Conversation
This was referenced Jan 2, 2025
Open
Closed
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
16c2fe0 to
0527483
Compare
This was referenced Jan 5, 2025
joneshf-dd
approved these changes
Jan 31, 2025
Contributor
joneshf-dd
left a comment
There was a problem hiding this comment.
Looks good for Language Tools!
Comment on lines
+17
to
+34
| format_multirun( | ||
| name = "format", | ||
| go = "@go_sdk//:bin/gofmt", | ||
| markdown = ":prettier", | ||
| starlark = "@buildifier_prebuilt//:buildifier", | ||
| yaml = "@aspect_rules_lint//format:yamlfmt", | ||
| ) | ||
|
|
||
| format_test( | ||
| name = "format_test", | ||
| size = "small", | ||
| go = "@go_sdk//:bin/gofmt", | ||
| markdown = ":prettier", | ||
| no_sandbox = True, | ||
| starlark = "@buildifier_prebuilt//:buildifier", | ||
| workspace = "//:WORKSPACE", | ||
| yaml = "@aspect_rules_lint//format:yamlfmt", | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WIP