Add BROTLI compression support for Parquet decoding#176
Open
Siya-05 wants to merge 1 commit intoDataHaskell:mainfrom
Open
Add BROTLI compression support for Parquet decoding#176Siya-05 wants to merge 1 commit intoDataHaskell:mainfrom
Siya-05 wants to merge 1 commit intoDataHaskell:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves Parquet page decompression by correctly handling
DataPageHeaderV2pages and adds support forBROTLIcompressed pages. The previous implementation decompressed the entire page payload based only on the column codec, which is incorrect forDataPageHeaderV2, where repetition and definition levels are stored as an uncompressed prefix and only the data body may be compressed (controlled bydataPageHeaderV2IsCompressed).Changes
DataPageHeaderV2decoding:prefix = repetitionLevelsBytes + definitionLevelsBytesbody = remaining bytesdataPageHeaderV2IsCompressed == Trueprefix <> decompressedBodyBROTLIis handled both for V2 (body-only) and non-V2 pages (full payload).prefixLen > compressedPageSizefor V2 pages, preventing silent corruption on malformed/truncated inputs.Notes
ZSTD,SNAPPY,UNCOMPRESSED,BROTLI) remains unchanged for non-V2 pages.refers to #166.