Skip to content

Fix nix and non-nix builds#178

Merged
mchav merged 2 commits intoDataHaskell:mainfrom
jisantuc:maint/js/provide-granite-as-derivation
Mar 5, 2026
Merged

Fix nix and non-nix builds#178
mchav merged 2 commits intoDataHaskell:mainfrom
jisantuc:maint/js/provide-granite-as-derivation

Conversation

@jisantuc
Copy link
Contributor

@jisantuc jisantuc commented Mar 5, 2026

This PR:

  • provides granite as a separate derivation, since granite in the upstream nixpkgs isn't >= 0.4
  • removes the attempted export of |> from DataFrame.Typed, since it doesn't exist
  • removes the import of & in DataFrame.Typed.Operations, since I went looking there for |> and saw it was unused

I also noticed while looking at this that all the examples are pinned to granite == 0.3.0.5, which... I don't think is gonna work with the granite dep in dataframe.cabal. I didn't want to expand to "make all the examples work", especially with the open issues for moving the examples to an examples repo where they can get hooked up with their own CI

@jisantuc jisantuc force-pushed the maint/js/provide-granite-as-derivation branch from c82f2ce to 6780713 Compare March 5, 2026 16:08
@mchav mchav merged commit e74c0ba into DataHaskell:main Mar 5, 2026
7 checks passed
@jisantuc jisantuc deleted the maint/js/provide-granite-as-derivation branch March 6, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants