Draft
Conversation
Signed-off-by: Zesky665 <zharkoc@gmail.com>
Signed-off-by: Zesky665 <zharkoc@gmail.com>
Signed-off-by: Zesky665 <zharkoc@gmail.com>
Collaborator
|
The test has been updated and expanded. It now checks the merchant, card assignment, and transaction tables. The test right now is flaky, because sometimes the transactions table (the ones with temporal joins) is not populated by the time the test query runs. As of the time of writing, there was an error with the finance-creditcard-example where trying to query the transactions data manually via graphql returned an error thrown by duckdb caused by duckdb receiving a empty result. PS: I changed the Apache-iceberg directory to a folder inside of the example directory for easier local debugging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporal joins don't seem to work with Iceberg.
Running
sqrl run -c package-analytics-simple.jsonworks.Running
sqrl run -c package-analytics-duckdb.jsondoes not.The scripts are identical. The only difference is postgres vs iceberg+duckdb.