Translate MAP ctor and element access to JSONB in Postgres dialect#1802
Open
ferenc-csaky wants to merge 1 commit intomainfrom
Open
Translate MAP ctor and element access to JSONB in Postgres dialect#1802ferenc-csaky wants to merge 1 commit intomainfrom
MAP ctor and element access to JSONB in Postgres dialect#1802ferenc-csaky wants to merge 1 commit intomainfrom
Conversation
e3b534c to
9596bf2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1802 +/- ##
============================================
- Coverage 13.42% 13.40% -0.02%
Complexity 734 734
============================================
Files 543 545 +2
Lines 15714 15735 +21
Branches 1829 1833 +4
============================================
Hits 2109 2109
- Misses 13413 13434 +21
Partials 192 192 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key changes
MapConstructorSqlTranslationcovers the ctor translationMapElementSqlTranslationcovers the element access with a heuristic which will only work for textual keys for now