Migrate from Google Guice to Spring Framework for dependency injection#1825
Draft
Migrate from Google Guice to Spring Framework for dependency injection#1825
Conversation
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
…ad of explicit @bean definitions Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
…ping Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1825 +/- ##
============================================
+ Coverage 13.19% 13.20% +0.01%
Complexity 734 734
============================================
Files 545 545
Lines 15982 15967 -15
Branches 1874 1875 +1
============================================
Hits 2109 2109
+ Misses 13681 13666 -15
Partials 192 192 ☔ View full report in Codecov by Sentry. |
221f378 to
53b9074
Compare
3 tasks
1144797 to
53b9074
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Injectannotations to usejakarta.injectpackage (JSR-330)@Configurationclasses with@BeanmethodsApplicationContextinstead of GuiceInjectorChanges
POM Updates
spring-framework.versionandjakarta.inject.versionproperties, removed Guice propertiesspring-contextandjakarta.inject-apicreateDependencyReducedPom=falseto shade plugin to preserve transitive dependenciesCode Changes
SqrlInjector: Converted from GuiceAbstractModuleto Spring@ConfigurationMockSqrlInjector: Same conversion for testsAbstractCompileCmd: Changed fromGuice.createInjector()toAnnotationConfigApplicationContextBaseCmd: Changed exception handling fromProvisionExceptiontoBeanCreationExceptionExecutionEnginesHolder: UsesAutowireCapableBeanFactoryfor dynamic engine instantiationcom.google.inject.*tojakarta.inject.*Test plan
🤖 Generated with Claude Code