Open
Conversation
…checks Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Collaborator
Author
|
Original idea came from slack |
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1865 +/- ##
============================================
+ Coverage 13.14% 13.55% +0.40%
- Complexity 742 774 +32
============================================
Files 550 551 +1
Lines 16137 16217 +80
Branches 1896 1915 +19
============================================
+ Hits 2122 2199 +77
+ Misses 13817 13816 -1
- Partials 198 202 +4 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FlinkConfigValidatorthat validatesengines.flink.configentries at compile time with 3 levels of checks:taskmanager-size,jobmanager-size, etc.) are placed inconfiginstead ofdeployment*Optionsclasses via reflection to build known keys/prefixes; warns on unrecognized keys with extra hint when the prefix is valid (likely typo)ErrorCollector.warn()so compilation is never blockedErrorCollectorintoFlinkStreamEngineconstructor to run validation on startupTest plan
FlinkConfigValidatorTest— 11 test cases covering all validation levels and edge cases🤖 Generated with Claude Code