Use Python Stable ABI in Swig build #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements Python Stable ABI (abi3) support for the SWIG-generated rundec Python wrapper. The main changes include:
- Adding Stable ABI macros to setup.py and rundec.i to enable building abi3-compatible wheels
- Updating from SWIG 4.2.0 to 4.3.0 with corresponding code generation changes
- Updating the minimum supported Python version from 2.7/3.5+ to 3.10+
- Modernizing the GitHub Actions workflow to build abi3 wheels
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Added py_limited_api=True and Py_LIMITED_API macro definition; updated version to 0.7 and author email |
| rundec.i | Added %begin block to define Py_LIMITED_API before SWIG includes |
| _rundec.cc | SWIG-generated file updated from 4.2.0 to 4.3.0 with Stable ABI compatibility changes |
| rundec.py | SWIG version comment updated from 4.2.0 to 4.3.0 |
| README.md | Updated Python version requirement from 2.7/3.5+ to 3.10+ |
| .github/workflows/wheels.yml | Added sdist build job, restricted wheel builds to cp310-* for abi3, updated OS versions, added release trigger |
| .github/workflows/test.yml | Updated test matrix from Python 3.7-3.10 to 3.10-3.14 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18
Also updated the version.
Still need to update the workflow