Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #48 画面上部と下部のグラフのトークンリワードAPRの表示のズレを修正する
の修正をいたしました!
comet-interface/components/pool/graph/RewardGraph.tsx
Line 8 in c2669cc
↑こちらで、usePoolDataからtokenRewardDataを参照して、画面上部の表示のロジックと一致させました!
comet-interface/components/pool/graph/GraphModel.tsx
Line 65 in c2669cc
comet-interface/components/pool/graph/GraphModel.tsx
Line 72 in c2669cc
↑こちらのtruncateTo3DecimalPlaces()関数で、小数点以下第三位までの数値にいたしましたが、
1.000%のように小数点第一位以下が0の場合、
1.100%のように第二位以下が0の場合、
1.110%のように第三位が0の場合、
0が消えて、それぞれ、1%、1.1%、1.11%の表記になってしまいまして、
↑のように、グラフでは小数点以下第三位までの小数で統一したかったので、
comet-interface/components/pool/graph/GraphModel.tsx
Line 126 in c2669cc
comet-interface/components/pool/graph/GraphModel.tsx
Line 138 in c2669cc
↑こちらのtoFixed(3)を使用しております!
toFixed(3)は意図的に残しております!