NVR triggered by object detection example #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new example notebook demonstrating an NVR (Network Video Recorder) system triggered by object detection. The system processes video streams using person detection models and generates notifications with video clips when persons are detected in specified zones.
- Adds a complete Jupyter notebook example showing smart NVR implementation with object detection, tracking, zone detection, and automated notifications
- Integrates the new notebook into the test suite to ensure it runs correctly
- Updates documentation to include the new example in the applications table
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/applications/smart_nvr.ipynb | New notebook implementing NVR with object detection, zone monitoring, and automated clip saving |
| tests/test_notebooks.py | Adds test configuration for the new smart_nvr notebook |
| README.md | Updates applications table to include the new smart NVR example |
| "hw_location = \"@cloud\"\n", | ||
| "model_zoo_url = \"degirum/public\"\n", | ||
| "model_name = \"yolo_v5s_person_det--512x512_quant_n2x_orca1_1\"\n", | ||
| "video_source = \"../../images/WalkingPerson.mp4\"\n", |
There was a problem hiding this comment.
The video file path '../../images/WalkingPerson.mp4' appears to be inconsistent with the test configuration in test_notebooks.py which uses 'Masked.mp4'. This could cause the test to fail or use a different video file than intended.
Suggested change
| "video_source = \"../../images/WalkingPerson.mp4\"\n", | |
| "video_source = \"../../images/Masked.mp4\"\n", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.