Fix/security header cookie logic

src/main/kotlin/core/packetproxy/extensions/securityheaders/checks/CookieCheck.kt

@@ -16,6 +16,8 @@
 package packetproxy.extensions.securityheaders.checks
 
 import packetproxy.extensions.securityheaders.SecurityCheck
+import packetproxy.extensions.securityheaders.SecurityCheck.HighlightSegment
+import packetproxy.extensions.securityheaders.SecurityCheck.HighlightType
 import packetproxy.extensions.securityheaders.SecurityCheckResult
 import packetproxy.http.HttpHeader
 
@@ -27,14 +29,27 @@ class CookieCheck : SecurityCheck {
     /** Check if a specific cookie line has the Secure flag */
     @JvmStatic
     fun hasSecureFlag(cookieLine: String): Boolean {
-      return cookieLine.lowercase().contains("secure")
+      val cookieContent = cookieLine.substringAfter(":", cookieLine).trim()
+
+      if (cookieContent.isEmpty()) {
+        return false
+      }
+
+      val parts = cookieContent.split(";")
+
+      return parts
+        .drop(1)
+        .map { it.trim().lowercase() }
+        .any { attr ->
+          val attrName = attr.split("=").first().trim()
+          attrName == "secure"
+        }
     }
   }
 
   override val name: String = "Cookies"
   override val columnName: String = "Cookies"
   override val failMessage: String = "Set-Cookie is missing 'Secure' flag"
-  override val greenPatterns: List<String> = listOf("set-cookie:", "secure")
 
   override fun check(header: HttpHeader, context: MutableMap<String, Any>): SecurityCheckResult {
     val setCookies = header.getAllValue("Set-Cookie")
@@ -50,13 +65,11 @@ class CookieCheck : SecurityCheck {
     val displayBuilder = StringBuilder()
 
     for (cookie in setCookies) {
-      if (!cookie.lowercase().contains(" secure")) {
+      if (!hasSecureFlag(cookie)) {
         allSecure = false
       }
 
-      // Truncate for display
-      val truncated = if (cookie.length > 100) cookie.substring(0, 100) + "..." else cookie
-      displayBuilder.append(truncated).append("; ")
+      displayBuilder.append(cookie).append("; ")
     }
 
     val displayValue = displayBuilder.toString()
@@ -72,4 +85,23 @@ class CookieCheck : SecurityCheck {
   override fun matchesHeaderLine(headerLine: String): Boolean {
     return headerLine.startsWith("set-cookie:")
   }
+
+  /**
+   * Highlight each Set-Cookie line based on whether it has the Secure flag.
+   * - Secure flag present: GREEN (secure)
+   * - Secure flag missing: RED (insecure)
+   */
+  override fun getHighlightSegments(
+    headerLine: String,
+    result: SecurityCheckResult?,
+  ): List<HighlightSegment> {
+    if (!matchesHeaderLine(headerLine.lowercase())) {
+      return emptyList()
+    }
+
+    val hasSecure = hasSecureFlag(headerLine)
+    val highlightType = if (hasSecure) HighlightType.GREEN else HighlightType.RED
+
+    return listOf(HighlightSegment(0, headerLine.length, highlightType))
+  }
 }

src/main/kotlin/core/packetproxy/extensions/securityheaders/ui/SecurityHeadersDetailPanel.kt

@@ -21,9 +21,11 @@ import javax.swing.JSplitPane
 import javax.swing.JTextPane
 import javax.swing.text.SimpleAttributeSet
 import javax.swing.text.StyledDocument
+import packetproxy.common.FontManager
 import packetproxy.extensions.securityheaders.SecurityCheck
 import packetproxy.extensions.securityheaders.SecurityCheckResult
 import packetproxy.extensions.securityheaders.checks.CookieCheck
+import packetproxy.gui.WrapEditorKit
 import packetproxy.http.HttpHeader
 
 /**
@@ -38,17 +40,8 @@ class SecurityHeadersDetailPanel(private val securityChecks: List<SecurityCheck>
   init {
     textStyles = TextStyles()
 
-    headerPane =
-      JTextPane().apply {
-        isEditable = false
-        background = Color.WHITE
-      }
-
-    detailArea =
-      JTextPane().apply {
-        isEditable = false
-        background = Color.WHITE
-      }
+    headerPane = createWrappedTextPane()
+    detailArea = createWrappedTextPane()
   }
 
   fun createPanel(): JSplitPane {
@@ -109,6 +102,15 @@ class SecurityHeadersDetailPanel(private val securityChecks: List<SecurityCheck>
     }
   }
 
+  private fun createWrappedTextPane(): JTextPane {
+    return JTextPane().apply {
+      isEditable = false
+      background = Color.WHITE
+      setEditorKit(WrapEditorKit(byteArrayOf()))
+      font = FontManager.getInstance().font
+    }
+  }
+
   private fun collectHighlightSegments(
     line: String,
     results: Map<String, SecurityCheckResult>,