-
Notifications
You must be signed in to change notification settings - Fork 16
Add parallel build support with -parallel and -jobs options #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
4d57a16 to
30878ea
Compare
|
@arthurbdiniz Did you notice you got feedback on this? There are no comments from you so it is a bit unclear, but you did push changes. Perhaps you want to comment explicitly asking Michael to re-review, or press the arrow button thing? |
a2e398d to
98eaf62
Compare
This allows faster builds by utilizing multiple CPU cores. Signed-off-by: Arthur Diniz <arthurbdiniz@gmail.com>
98eaf62 to
e824d8e
Compare
|
Pull Request updated, waiting for another review. |
| log.Printf("building %s failed: %v\n", src, result.err) | ||
| } | ||
|
|
||
| resultsMu.Lock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add defer resultsMu.Unlock() after this line and remove the explicit resultsMu.Unlock() below. It’s good style to defer the unlocking so that one can’t forget it in any code path below.
This commit introduces parallel package building to ratt.
-parallelenables parallel builds.-jobscontrols the number of concurrent workers (default: number of CPU cores, must be > 0).buildPackagesSequentialandbuildPackagesParallelhelpers.This allows faster builds by utilizing multiple CPU cores.
Example: