Skip to content

feat(queue): add e2e tests for fast-v2v and restyle-v2v#83

Merged
AdirAmsalem merged 6 commits intomainfrom
e2e-test-coverage-and-helpers
Feb 15, 2026
Merged

feat(queue): add e2e tests for fast-v2v and restyle-v2v#83
AdirAmsalem merged 6 commits intomainfrom
e2e-test-coverage-and-helpers

Conversation

@AdirAmsalem
Copy link
Contributor

@AdirAmsalem AdirAmsalem commented Feb 15, 2026

Summary

  • Add missing e2e tests for lucy-fast-v2v and lucy-restyle-v2v video models
  • Unify expectProcessResult and expectQueueResult into a single expectResult helper that handles both Blob and QueueJobResult
  • Add job_id to QueueJobResult type so failed jobs surface the job ID in errors
  • Fix .gitignore path and remove accidentally committed e2e output files

Note

Medium Risk
Public SDK typing/output for queue.submitAndPoll changes to always include job_id, which may require downstream type updates. New Playwright/Vitest browser dependencies and concurrent/retry behavior may affect CI stability and runtime.

Overview
Adds new E2E coverage in the SDK: video queue tests now include lucy-fast-v2v and lucy-restyle-v2v variants, and a separate Playwright-powered browser E2E suite is introduced for realtime models (wired via test:e2e:realtime and a new Vitest config).

Queue polling now returns job_id in both success and failure QueueJobResult variants, and the existing E2E tests are refactored to use a single expectResult helper that can validate either direct Blob results or queued job results. Minor repo hygiene changes include fixing the ignored E2E output path and excluding the realtime browser test from the default Vitest config.

Written by Cursor Bugbot for commit 64953d2. This will update automatically on new commits. Configure here.

… helpers

- Add missing e2e tests for lucy-fast-v2v and lucy-restyle-v2v
- Unify expectResult helper to handle both Blob and QueueJobResult
- Add job_id to QueueJobResult type for better failure diagnostics
- Fix .gitignore path for e2e-output directory
- Remove accidentally committed e2e output files
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 15, 2026

Open in StackBlitz

npm i https://pkg.pr.new/DecartAI/sdk/@decartai/sdk@83

commit: 64953d2

@AdirAmsalem AdirAmsalem changed the title feat(queue): add e2e tests for fast-v2v and restyle-v2v, improve test helpers feat(queue): add e2e tests for fast-v2v and restyle-v2v Feb 15, 2026
…eference image scenarios

- Updated the test for lucy-restyle-v2v to include a prompt in the description.
- Added a new test case for lucy-restyle-v2v using a reference image, improving coverage for video restyling functionality.
- Adjusted expected result identifiers to reflect the new test scenarios.
Add e2e tests for all 4 realtime models (mirage, mirage_v2,
lucy_v2v_720p_rt, lucy_2_rt) running in headless Chromium via
@vitest/browser and Playwright.

- Synthetic canvas stream avoids needing a real camera
- Tests connect, verify session, send prompt, and disconnect
- API key injected via Vite define from DECART_API_KEY env var
- New test:e2e:realtime script in package.json
- Removed fallback for DECART_API_KEY in vitest config to ensure it is always defined.
- Enhanced vitest configuration for e2e tests by specifying test files directly.
- Refactored e2e-realtime tests to streamline the test flow and improve readability, including reducing timeout and retry logic.
- Updated test descriptions and assertions for clarity and consistency.
- Updated vitest configuration to exclude the `e2e-realtime.test.ts` file from test runs.
- Enhanced cleanup in the `e2e-realtime.test.ts` by ensuring all media tracks are stopped after tests to prevent resource leaks.
- Updated the cleanup logic in `e2e-realtime.test.ts` to use a for-of loop for stopping media tracks, improving readability and consistency in resource management.
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@AdirAmsalem AdirAmsalem merged commit 0a6df47 into main Feb 15, 2026
5 checks passed
@AdirAmsalem AdirAmsalem deleted the e2e-test-coverage-and-helpers branch February 15, 2026 11:58
Copy link
Contributor

@tomershlasky tomershlasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments