feat(realtime): expose queue status and position events#86
Open
AdirAmsalem wants to merge 1 commit intomainfrom
Open
feat(realtime): expose queue status and position events#86AdirAmsalem wants to merge 1 commit intomainfrom
AdirAmsalem wants to merge 1 commit intomainfrom
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainrealtime architecture.statusandqueue_positionmessage handling through WebRTC connection and realtime client events.onStatusandonQueuePositionconnect callbacks, and add unit tests covering both event and callback flows.Validation
pnpm formatpnpm test tests/unit.test.tspnpm typecheckpnpm buildNote
Low Risk
Additive event/callback plumbing and type updates with unit coverage; low risk aside from potential minor compatibility impact for consumers relying on strict event typings.
Overview
Surfaces server queue updates end-to-end in realtime mode by adding websocket message types for
statusandqueue_position, wiring them throughWebRTCConnection’s emitter, and exposing them fromRealTimeClientas newstatusandqueuePositionevents.connect()now accepts optionalonStatusandonQueuePositioncallbacks (validated via zod) that fire alongside event emission, and unit tests were added to cover both the event-based and callback-based flows.Written by Cursor Bugbot for commit 7af30d7. This will update automatically on new commits. Configure here.