xiter: use code generation to more seamlessly support GOEXPERIMENT=rangefunc
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will (attempt to) copy the types, and will use the coroutine version of "Pull" (which performs much better). The old goroutine version of Pull is renamed GoPull, and is used for Pull when the rangefunc GOEXPERIMENT is not set.
DeedleFake
force-pushed
the
goexperiment-rangefunc
branch
from
d619bb8 to
4a379dc
Compare
Owner
Author
|
This now works and all tests pass. It just needs to copy the godoc comments to the generated functions, I think. Thoughts, @dr2chase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2.