Conversation
|
this typo is actually intentional. Naming objects "Placement" used to make expression engine crash, most likely because of ambiguity with object's Placement property. |
|
Ah, ok. Since you said name, I am guessing the label can have this typo fixed. Am I right? If yes, then I could fix the label them, if you are interested. What about the other changes removing colon from the menu items? Are they good? |
|
labels are treated as names by the expression engine, aren't they? I don't remember if there is a story behind the colons. Could be to make it obvious that it's a group command in the customization dialog (where one can customize toolbars and bind keyboard shortcuts). I don't have any strong opinions about them. |
Sorry, forgot this question. We use names this way But in this case, I don't see any problem with fixing the label to use "Placement". Do you see it? |
|
i have checked FreeCAD v1.0, and it deals with the ambiguity just fine somehow. If the support for older FreeCAD can be ditched (it is kinda spotty anyway; the actual problem was very long ago so it might be no one is affected anyway), i might just go for it, including names... |
|
@DeepSOIC should I close this PR? |
Hi @DeepSOIC this PR removes extra colon from some menus stated here, #108 and also fix a typo on the "Placement" that was "Placment" before.