Skip to content

Conversation

@jaayzee
Copy link
Contributor

@jaayzee jaayzee commented Nov 18, 2025

Description

Made the wifi and wired dropdown rendering conditional on whether or not wifi is detected in features.

Type of change

Please select all that apply.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Other: [describe here]

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Make sure code runs/builds on Linux [REQUIRED]
    • Code produces no console errors upon launching the software
  • Other (add any other tests run)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added 1 or more reviewers to my pull request
    • Reviewer has run the above tests to verify
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Myself or a reviewer has tested my code to prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (if applicable)
  • Any dependent changes have been merged and published in downstream modules

@jaayzee jaayzee requested a review from brandonhs November 18, 2025 19:45
# server = Server(FeatureSupport.none(), sio, app, settings_path='.')
server = Server(
FeatureSupport.all(), sio, app, settings_path=".", log_level=logging.DEBUG
FeatureSupport.none(), sio, app, settings_path=".", log_level=logging.DEBUG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FeatureSupport.none should not always be set

@brandonhs brandonhs merged commit 36a45c9 into main Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants